Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211423004: Change static library targets in safe_json GN files to source sets. (Closed)

Created:
5 years, 5 months ago by Bernhard Bauer
Modified:
5 years, 5 months ago
Reviewers:
Robert Sesek, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change static library targets in safe_json GN files to source sets. Committed: https://crrev.com/53e230a8e16c732966545622bd0b46b619e59ca4 Cr-Commit-Position: refs/heads/master@{#338003}

Patch Set 1 #

Patch Set 2 : defines #

Total comments: 2

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M components/safe_json.gypi View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M components/safe_json/BUILD.gn View 1 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bernhard Bauer
Please review.
5 years, 5 months ago (2015-07-08 21:31:56 UTC) #2
Robert Sesek
lgtm https://codereview.chromium.org/1211423004/diff/20001/components/safe_json.gypi File components/safe_json.gypi (right): https://codereview.chromium.org/1211423004/diff/20001/components/safe_json.gypi#newcode10 components/safe_json.gypi:10: #'type': '<(component)', Delete this, since it's not going ...
5 years, 5 months ago (2015-07-08 22:01:57 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/1211423004/diff/20001/components/safe_json.gypi File components/safe_json.gypi (right): https://codereview.chromium.org/1211423004/diff/20001/components/safe_json.gypi#newcode10 components/safe_json.gypi:10: #'type': '<(component)', On 2015/07/08 22:01:57, Robert Sesek wrote: > ...
5 years, 5 months ago (2015-07-09 08:17:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211423004/30001
5 years, 5 months ago (2015-07-09 08:17:24 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 5 months ago (2015-07-09 09:16:05 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 09:17:04 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/53e230a8e16c732966545622bd0b46b619e59ca4
Cr-Commit-Position: refs/heads/master@{#338003}

Powered by Google App Engine
This is Rietveld 408576698