components/safe_json.gypi - Issue 1211423004: Change static library targets in safe_json GN files to source sets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_json.gypi

Issue 1211423004: Change static library targets in safe_json GN files to source sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/safe_json.gypi

diff --git a/components/safe_json.gypi b/components/safe_json.gypi

index b7ab6084ec97793f9fcab7ee10ff989a6fbf163c..dcf28244576f26b744c4671f41f77931e2c7569f 100644

--- a/components/safe_json.gypi

+++ b/components/safe_json.gypi

@@ -7,7 +7,6 @@

{

# GN version: //components/safe_json

'target_name': 'safe_json',

- #'type': '<(component)',

'type': 'static_library',

'dependencies': [

'safe_json_parser_message_filter',

@@ -19,9 +18,6 @@

'include_dirs': [

'..',

- 'defines': [

- 'SAFE_JSON_IMPLEMENTATION',

- ],

'sources': [

'safe_json/safe_json_parser.cc',

'safe_json/safe_json_parser.h',

« no previous file with comments | « no previous file | components/safe_json/BUILD.gn » ('j') | no next file with comments »