Issue 1211253015: Revert "Start the migration of passwords from the Keychain."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211253015: Revert "Start the migration of passwords from the Keychain." (Closed)

Created:
5 years, 5 months ago by asargent_no_longer_on_chrome

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, asvitkine+watch_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Start the migration of passwords from the Keychain." This reverts commit b312da5608ac316b7e49459c906b5a5d72332776. This was causing failures on the Mac Asan 64 bot. See crbug.com/508227 for details. BUG=508227, 466638 Committed: https://chromium.googlesource.com/chromium/src/+/5b4ea4b1fa1a7b66f73f971ad05ea3693818ca8f

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -377 lines)			Patch
M	chrome/browser/password_manager/password_store_factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac_unittest.cc	View	5 chunks	+46 lines, -16 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_proxy_mac.h	View	4 chunks	+2 lines, -26 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_proxy_mac.cc	View	3 chunks	+12 lines, -84 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_proxy_mac_unittest.cc	View	11 chunks	+14 lines, -149 lines	0 comments	Download
M	chrome/browser/password_manager/simple_password_store_mac.h	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/password_manager/simple_password_store_mac.cc	View	1 chunk	+7 lines, -14 lines	0 comments	Download
M	chrome/browser/password_manager/simple_password_store_mac_unittest.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	components/password_manager.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	components/password_manager/core/browser/keychain_migration_status_mac.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	components/password_manager/core/browser/password_manager.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	components/password_manager/core/browser/password_store_default.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	components/password_manager/core/common/password_manager_pref_names.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	components/password_manager/core/common/password_manager_pref_names.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

5 years, 5 months ago (2015-07-08 18:30:45 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5b4ea4b1fa1a7b66f73f971ad05ea3693818ca8f.

Expand Messages | Collapse Messages