components/password_manager/core/browser/password_manager.cc - Issue 1211253015: Revert "Start the migration of passwords from the Keychain."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1211253015: Revert "Start the migration of passwords from the Keychain." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/keychain_migration_status_mac.h ('k') | components/password_manager/core/browser/password_store_default.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 66b8a6d7ba300d4741cad54a713de61db2242f63..1e7ac9dab35dec9de67cda451f5ccdde0ce1ff7a 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -17,7 +17,6 @@

#include "components/autofill/core/common/password_form_field_prediction_map.h"

#include "components/password_manager/core/browser/affiliation_utils.h"

#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"

-#include "components/password_manager/core/browser/keychain_migration_status_mac.h"

#include "components/password_manager/core/browser/password_autofill_manager.h"

#include "components/password_manager/core/browser/password_form_manager.h"

#include "components/password_manager/core/browser/password_manager_client.h"

@@ -143,10 +142,6 @@ void PasswordManager::RegisterProfilePrefs(

registry->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords,

true);

registry->RegisterListPref(prefs::kPasswordManagerGroupsForDomains);

-#if defined(OS_MACOSX)

- registry->RegisterIntegerPref(prefs::kKeychainMigrationStatus,

- static_cast<int>(MigrationStatus::NOT_STARTED));

-#endif

}

#if defined(OS_WIN)