Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1211243005: ARM: lowerSelect for integers. (Closed)

Created:
5 years, 5 months ago by jvoung (off chromium)
Modified:
5 years, 5 months ago
Reviewers:
Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ARM: lowerSelect for integers. No bool-folding optimization, just the straightforward compare followed by mov and conditional mov. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e0df91fe831421269351efa5fa64dc2f31502e6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -14 lines) Patch
M src/IceConditionCodesX8664.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 2 chunks +46 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 3 chunks +37 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 4 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 5 months ago (2015-06-30 00:49:27 UTC) #2
Jim Stichnoth
lgtm
5 years, 5 months ago (2015-06-30 14:18:46 UTC) #3
jvoung (off chromium)
5 years, 5 months ago (2015-06-30 15:47:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0df91fe831421269351efa5fa64dc2f31502e6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698