Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211033002: Set icon for Chrome Webstore Gallery Widget app (Closed)

Created:
5 years, 6 months ago by tbarzic
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set icon for Chrome Webstore Gallery Widget app BUG=439448 Committed: https://crrev.com/57d497bef2eed2aca68f677c211b4f506eed6234 Cr-Commit-Position: refs/heads/master@{#336226}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/extensions/chrome_component_extension_resource_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/chrome_apps/webstore_widget/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
M components/chrome_apps/webstore_widget_resources.grdp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1129083006 Patch 60001

Messages

Total messages: 8 (3 generated)
tbarzic
5 years, 6 months ago (2015-06-25 18:23:07 UTC) #2
Reilly Grant (use Gerrit)
lgtm with one nit https://codereview.chromium.org/1211033002/diff/1/components/chrome_apps/webstore_widget_resources.grdp File components/chrome_apps/webstore_widget_resources.grdp (right): https://codereview.chromium.org/1211033002/diff/1/components/chrome_apps/webstore_widget_resources.grdp#newcode14 components/chrome_apps/webstore_widget_resources.grdp:14: <!-- Widget container resoruces: --> ...
5 years, 6 months ago (2015-06-25 18:26:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211033002/20001
5 years, 6 months ago (2015-06-25 18:29:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 19:25:01 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 19:26:02 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/57d497bef2eed2aca68f677c211b4f506eed6234
Cr-Commit-Position: refs/heads/master@{#336226}

Powered by Google App Engine
This is Rietveld 408576698