Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129083006: Show an error dialog if Chrome Web Store widget fails to load (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@launching_webstore_widget_app
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show an error dialog if Chrome Web Store widget fails to load BUG=477106 Committed: https://crrev.com/870414d6552db5c5b012fb13531fdaf433a7b5cd Cr-Commit-Position: refs/heads/master@{#330106}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : s/close/closeAppWindow/ #

Patch Set 4 : remove unneeded \n #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M components/chrome_apps/webstore_widget/app/main.js View 1 2 4 chunks +30 lines, -5 lines 0 comments Download
M components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js View 3 chunks +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1211033002 Patch 1
Issue 1211033002 Patch 20001

Messages

Total messages: 9 (3 generated)
tbarzic
5 years, 7 months ago (2015-05-08 22:38:16 UTC) #2
yoshiki
lgtm with nit https://codereview.chromium.org/1129083006/diff/20001/components/chrome_apps/webstore_widget/app/main.js File components/chrome_apps/webstore_widget/app/main.js (right): https://codereview.chromium.org/1129083006/diff/20001/components/chrome_apps/webstore_widget/app/main.js#newcode158 components/chrome_apps/webstore_widget/app/main.js:158: function close() { nit: this overrides ...
5 years, 7 months ago (2015-05-12 13:57:15 UTC) #3
tbarzic
https://codereview.chromium.org/1129083006/diff/20001/components/chrome_apps/webstore_widget/app/main.js File components/chrome_apps/webstore_widget/app/main.js (right): https://codereview.chromium.org/1129083006/diff/20001/components/chrome_apps/webstore_widget/app/main.js#newcode158 components/chrome_apps/webstore_widget/app/main.js:158: function close() { On 2015/05/12 13:57:15, yoshiki wrote: > ...
5 years, 7 months ago (2015-05-12 20:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129083006/60001
5 years, 7 months ago (2015-05-15 16:01:03 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-15 16:32:06 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:33:49 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/870414d6552db5c5b012fb13531fdaf433a7b5cd
Cr-Commit-Position: refs/heads/master@{#330106}

Powered by Google App Engine
This is Rietveld 408576698