chrome/browser/ui/webui/options/options_handlers_helper.cc - Issue 1211003006: [Extensions OOPI] Update app window bindings for OOPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_handlers_helper.cc

Issue 1211003006: [Extensions OOPI] Update app window bindings for OOPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | content/public/renderer/render_frame.h » ('j') | extensions/browser/api/app_window/app_window_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_handlers_helper.cc

diff --git a/chrome/browser/ui/webui/options/options_handlers_helper.cc b/chrome/browser/ui/webui/options/options_handlers_helper.cc

index b8bda6adf9a82a25246482de79b934212abc2119..3f06176a77e2bc58530485abaa218fc6023ea057 100644

--- a/chrome/browser/ui/webui/options/options_handlers_helper.cc

+++ b/chrome/browser/ui/webui/options/options_handlers_helper.cc

@@ -26,7 +26,7 @@ chrome::HostDesktopType GetDesktopType(content::WebUI* web_ui) {

extensions::AppWindow* app_window =

extensions::AppWindowRegistry::Get(Profile::FromWebUI(web_ui))

- ->GetAppWindowForRenderViewHost(web_contents->GetRenderViewHost());

+ ->GetAppWindowForWebContents(web_contents);

if (app_window) {

return chrome::GetHostDesktopTypeForNativeWindow(

app_window->GetNativeWindow());