chrome/browser/extensions/extension_tab_util.cc - Issue 1211003006: [Extensions OOPI] Update app window bindings for OOPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 1211003006: [Extensions OOPI] Update app window bindings for OOPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index f1783f72ecba294145bea60075ecb628e8dd1d18..fb368a17248a7de5cec668923d896c84a95119e4 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -55,8 +55,7 @@ WindowController* GetAppWindowController(const WebContents* contents) {

AppWindowRegistry* registry = AppWindowRegistry::Get(profile);

if (!registry)

return NULL;

- AppWindow* app_window =

- registry->GetAppWindowForRenderViewHost(contents->GetRenderViewHost());

+ AppWindow* app_window = registry->GetAppWindowForWebContents(contents);

if (!app_window)

return NULL;

return WindowControllerList::GetInstance()->FindWindowById(

« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/options_handlers_helper.cc » ('j') | extensions/browser/api/app_window/app_window_api.cc » ('J')