Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9184)

Unified Diff: chrome/renderer/spellchecker/spellcheck_provider.h

Issue 1210943008: Patch 2: Added a preprocessor flag for platform spellcheck. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_spellcheck_flag
Patch Set: Added a preprocessor flag for Android spellcheck. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/spellchecker/spellcheck_provider.h
diff --git a/chrome/renderer/spellchecker/spellcheck_provider.h b/chrome/renderer/spellchecker/spellcheck_provider.h
index 793b39187dbe1b1354dffee0470bd6d413e07aa2..0abaacbec2d835335ace9396cbd11fa8ebae1c58 100644
--- a/chrome/renderer/spellchecker/spellcheck_provider.h
+++ b/chrome/renderer/spellchecker/spellcheck_provider.h
@@ -91,25 +91,25 @@ class SpellCheckProvider
void updateSpellingUIWithMisspelledWord(
const blink::WebString& word) override;
-#if !defined(OS_MACOSX)
+#if !defined(USE_PLATFORM_SPELLCHECKER)
void OnRespondSpellingService(
int identifier,
bool succeeded,
const base::string16& text,
const std::vector<SpellCheckResult>& results);
-#endif
+#endif // !USE_PLATFORM_SPELLCHECKER
// Returns whether |text| has word characters, i.e. whether a spellchecker
// needs to check this text.
bool HasWordCharacters(const base::string16& text, int index) const;
-#if defined(OS_MACOSX)
+#if defined(USE_PLATFORM_SPELLCHECKER)
void OnAdvanceToNextMisspelling();
void OnRespondTextCheck(
int identifier,
const std::vector<SpellCheckResult>& results);
void OnToggleSpellPanel(bool is_currently_visible);
-#endif
+#endif // USE_PLATFORM_SPELLCHECKER
please use gerrit instead 2015/07/02 04:27:06 Here and everywhere else: Let's try to preserve th
dylanking 2015/07/07 02:31:22 Fixed in https://codereview.chromium.org/122755300
dylanking 2015/07/07 19:02:15 Now fixed here, too.
// Holds ongoing spellchecking operations, assigns IDs for the IPC routing.
WebTextCheckCompletions text_check_completions_;

Powered by Google App Engine
This is Rietveld 408576698