Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1210943005: Use general instruction/stack pointer convenience method instead of manually (Closed)

Created:
5 years, 5 months ago by liuandrew
Modified:
5 years, 5 months ago
Reviewers:
srutherford, ahonig, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Use general instruction/stack pointer convenience method instead of manually finding the instruction/stack pointer for exploitability rating. There was already a method that found the instruction pointer, so the files for exploitability ratings had repeated code. Also a method for finding the stack pointer is implemented in this CL. R=ivanpe@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1468

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -33 lines) Patch
M src/google_breakpad/common/minidump_cpu_ppc.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/google_breakpad/common/minidump_cpu_ppc64.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/google_breakpad/common/minidump_cpu_sparc.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/google_breakpad/processor/dump_context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/processor/dump_context.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/processor/exploitability_linux.cc View 2 chunks +4 lines, -21 lines 0 comments Download
M src/processor/exploitability_win.cc View 1 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
liuandrew
5 years, 5 months ago (2015-06-30 23:01:52 UTC) #2
ivanpe
LGTM https://codereview.chromium.org/1210943005/diff/1/src/processor/exploitability_win.cc File src/processor/exploitability_win.cc (right): https://codereview.chromium.org/1210943005/diff/1/src/processor/exploitability_win.cc#newcode115 src/processor/exploitability_win.cc:115: // TODO(liuandrew): get the stack ptr Is this ...
5 years, 5 months ago (2015-06-30 23:17:09 UTC) #3
liuandrew
Removed old TODO. Comitting this patch. https://codereview.chromium.org/1210943005/diff/1/src/processor/exploitability_win.cc File src/processor/exploitability_win.cc (right): https://codereview.chromium.org/1210943005/diff/1/src/processor/exploitability_win.cc#newcode115 src/processor/exploitability_win.cc:115: // TODO(liuandrew): get ...
5 years, 5 months ago (2015-06-30 23:20:51 UTC) #4
liuandrew
5 years, 5 months ago (2015-06-30 23:22:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:10008) manually as r1468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698