Use general instruction/stack pointer convenience method instead of manually

src/processor/exploitability_win.cc

 // Copyright (c) 2010 Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 88 matching lines @@
     memory_available = false;
   }
   uint64_t address = process_state_->crash_address();
   uint32_t exception_code = raw_exception->exception_record.exception_code;
 
   uint32_t exploitability_weight = 0;
 
   uint64_t stack_ptr = 0;
   uint64_t instruction_ptr = 0;
 
-  switch (context->GetContextCPU()) {
-    case MD_CONTEXT_X86:
-      stack_ptr = context->GetContextX86()->esp;
-      instruction_ptr = context->GetContextX86()->eip;
-      break;
-    case MD_CONTEXT_AMD64:
-      stack_ptr = context->GetContextAMD64()->rsp;
-      instruction_ptr = context->GetContextAMD64()->rip;
-      break;
-    default:
-      BPLOG(INFO) << "Unsupported architecture.";
-      return EXPLOITABILITY_ERR_PROCESSING;
+  // Getting the instruction pointer.
+  if (!context->GetInstructionPointer(&instruction_ptr)) {
+    return EXPLOITABILITY_ERR_PROCESSING;
+  }
+
+  // Getting the stack pointer.
+  // TODO(liuandrew): get the stack ptr

[ivanpe, 2015/06/30 23:17:09]

Is this TODO still relevant?

[liuandrew, 2015/06/30 23:20:51]

Nope. Removed.

+  if (!context->GetStackPointer(&stack_ptr)) {
+    return EXPLOITABILITY_ERR_PROCESSING;
   }
 
   // Check if we are executing on the stack.
   if (instruction_ptr <= (stack_ptr + kProbableStackOffset) &&
       instruction_ptr >= (stack_ptr - kProbableStackOffset))
     exploitability_weight += kHugeBump;
 
   switch (exception_code) {
     // This is almost certainly recursion.
     case MD_EXCEPTION_CODE_WIN_STACK_OVERFLOW:
@@ skipping 147 matching lines @@
     return EXPLOITABLITY_MEDIUM;
   if (exploitability_weight >= kLowCutoff)
     return EXPLOITABILITY_LOW;
   if (exploitability_weight >= kInterestingCutoff)
     return EXPLOITABILITY_INTERESTING;
 
   return EXPLOITABILITY_NONE;
 }
 
 }  // namespace google_breakpad