Update navigator.services API to use the new services.onconnect event [1/3].

Update navigator.services API to use the new services.onconnect event [1/3].

This is part of a series of patches to change the service side API from
a global oncrossoriginconnect event to a new navigator.services.onconnect
event.

This patch adds the new event to blink as well as adds APIs so the new
event can be dispatched, follow up patches change the content level
code to use the new event and remove the old event.

[1/3] This patch
[2/3] https://codereview.chromium.org/1210643002
      Updates content side of the code.
[3/3] https://codereview.chromium.org/1205783004
      Removes old event from blink and adds some tests specific to
      the new event.

BUG=426458
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198541

[Marijn Kruisselbrink, 2015-07-02 00:50:52]

mek@chromium.org changed reviewers:
+ chasej@chromium.org

[Marijn Kruisselbrink, 2015-07-02 00:50:53]

Jason: if you want to review some of my code, this is probably a good place to
start. It might not make sense to review part 2 of this yet though, since there
is active ongoing discussion as to how event dispatching with mojo is supposed
to work.

[chasej, 2015-07-02 20:44:56]

On 2015/07/02 00:50:53, Marijn Kruisselbrink wrote:
> Jason: if you want to review some of my code, this is probably a good place to
> start. It might not make sense to review part 2 of this yet though, since
there
> is active ongoing discussion as to how event dispatching with mojo is supposed
> to work.

I'm still learning about the mojo bits, but the rest makes sense to me. Added a
couple minor comments.

[chasej, 2015-07-02 20:45:28]

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
File Source/modules/navigatorconnect/AcceptConnectionObserver.cpp (right):

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
Source/modules/navigatorconnect/AcceptConnectionObserver.cpp:106: return
ScriptPromise::rejectWithDOMException(scriptState,
DOMException::create(InvalidStateError, "respondWith wsa already called."));
Typo: "wsa" should be "was"

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
File Source/modules/navigatorconnect/ServicePortCollection.h (right):

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
Source/modules/navigatorconnect/ServicePortCollection.h:9: #include
"bindings/core/v8/SerializedScriptValueFactory.h"
Is this include needed?  It doesn't seem so for the declaration of
dispatchConnectEvent().  (I haven't tried to compile this patch locally though)

[Marijn Kruisselbrink, 2015-07-07 16:42:49]

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
File Source/modules/navigatorconnect/AcceptConnectionObserver.cpp (right):

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
Source/modules/navigatorconnect/AcceptConnectionObserver.cpp:106: return
ScriptPromise::rejectWithDOMException(scriptState,
DOMException::create(InvalidStateError, "respondWith wsa already called."));
On 2015/07/02 at 20:45:28, chasej wrote:
> Typo: "wsa" should be "was"

Done

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
File Source/modules/navigatorconnect/ServicePortCollection.h (right):

https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
Source/modules/navigatorconnect/ServicePortCollection.h:9: #include
"bindings/core/v8/SerializedScriptValueFactory.h"
On 2015/07/02 at 20:45:28, chasej wrote:
> Is this include needed?  It doesn't seem so for the declaration of
dispatchConnectEvent().  (I haven't tried to compile this patch locally though)

No, it's not needed here. Must have been a leftover from some older patch...

[Marijn Kruisselbrink, 2015-07-07 16:47:56]

mek@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[Marijn Kruisselbrink, 2015-07-07 16:47:56]

+yhirano for bindings/ OWNERS
+japhet for public/ OWNERS and Source/web OWNERS

[Nate Chapin, 2015-07-07 18:36:15]

public/ lgtm

[yhirano, 2015-07-08 01:55:47]

bindings/ lgtm

[chasej, 2015-07-08 20:15:15]

On 2015/07/07 16:42:49, Marijn Kruisselbrink wrote:
>
https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
> File Source/modules/navigatorconnect/AcceptConnectionObserver.cpp (right):
> 
>
https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
> Source/modules/navigatorconnect/AcceptConnectionObserver.cpp:106: return
> ScriptPromise::rejectWithDOMException(scriptState,
> DOMException::create(InvalidStateError, "respondWith wsa already called."));
> On 2015/07/02 at 20:45:28, chasej wrote:
> > Typo: "wsa" should be "was"
> 
> Done
> 
>
https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
> File Source/modules/navigatorconnect/ServicePortCollection.h (right):
> 
>
https://codereview.chromium.org/1210633002/diff/80001/Source/modules/navigato...
> Source/modules/navigatorconnect/ServicePortCollection.h:9: #include
> "bindings/core/v8/SerializedScriptValueFactory.h"
> On 2015/07/02 at 20:45:28, chasej wrote:
> > Is this include needed?  It doesn't seem so for the declaration of
> dispatchConnectEvent().  (I haven't tried to compile this patch locally
though)
> 
> No, it's not needed here. Must have been a leftover from some older patch...

lgtm

[Marijn Kruisselbrink, 2015-07-08 20:26:18]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2015-07-08 20:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210633002/120001

[commit-bot: I haz the power, 2015-07-08 20:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 20:29:46]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/62190)

[Marijn Kruisselbrink, 2015-07-08 22:07:37]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2015-07-08 22:07:38]

The patchset sent to the CQ was uploaded after l-g-t-m from chasej@chromium.org,
japhet@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1210633002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-08 22:08:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210633002/140001

[commit-bot: I haz the power, 2015-07-08 22:33:26]

Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198541