Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1205783004: Update navigator.services API to use the new services.onconnect event [3/3]. (Closed)

Created:
5 years, 6 months ago by Marijn Kruisselbrink
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@serviceport-serviceside
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update navigator.services API to use the new services.onconnect event [2/3]. This is part of a series of patches to change the service side API from a global oncrossoriginconnect event to a new navigator.services.onconnect event. This patch removes the old event from blink and adds some tests specific to the new event. [1/3] https://codereview.chromium.org/1210633002 Adds new event to blink. [2/3] https://codereview.chromium.org/1210643002 Updates content side of the code. [3/3] This patch BUG=426458 Committed: https://crrev.com/48a8914ca0253b908f73d5b36118223fc7b06ff2 git-svn-id: svn://svn.chromium.org/blink/trunk@199691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : fix webexposed layout test #

Total comments: 1

Patch Set 8 : remove extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -237 lines) Patch
A LayoutTests/http/tests/navigatorconnect/connect-event.html View 1 2 3 4 5 6 7 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/accepting-worker.js View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/async-connect-worker.js View 1 chunk +0 lines, -10 lines 0 comments Download
A LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js View 1 2 3 4 5 6 7 1 chunk +129 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/echo-worker.js View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/rejecting-worker.js View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/navigatorconnect/resources/reply-client-info-worker.js View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 1 2 3 4 5 6 7 3 chunks +0 lines, -4 lines 0 comments Download
M Source/modules/navigatorconnect/AcceptConnectionObserver.h View 1 2 3 3 chunks +3 lines, -10 lines 0 comments Download
M Source/modules/navigatorconnect/AcceptConnectionObserver.cpp View 1 2 3 4 5 4 chunks +1 line, -43 lines 0 comments Download
D Source/modules/navigatorconnect/CrossOriginConnectEvent.h View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/modules/navigatorconnect/CrossOriginConnectEvent.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/modules/navigatorconnect/CrossOriginConnectEvent.idl View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/modules/navigatorconnect/ServiceWorkerGlobalScopeNavigatorConnect.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/navigatorconnect/ServiceWorkerGlobalScopeNavigatorConnect.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 5 6 7 2 chunks +0 lines, -10 lines 0 comments Download
M public/web/WebServiceWorkerContextClient.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Marijn Kruisselbrink
Ben: could you review this?
5 years, 5 months ago (2015-07-21 21:07:06 UTC) #2
bsittler
lgtm https://codereview.chromium.org/1205783004/diff/120001/LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js File LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js (right): https://codereview.chromium.org/1205783004/diff/120001/LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js#newcode8 LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js:8: var resolveMethod, rejectMethod; one extra space
5 years, 4 months ago (2015-07-29 17:52:33 UTC) #3
Marijn Kruisselbrink
+japhet for public/, Source/core/ and Source/web/ OWNERS
5 years, 4 months ago (2015-07-29 17:58:27 UTC) #5
Nate Chapin
Red is a wonderful color. LGTM
5 years, 4 months ago (2015-07-29 23:43:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205783004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1205783004/140001
5 years, 4 months ago (2015-07-29 23:52:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38731)
5 years, 4 months ago (2015-07-29 23:57:59 UTC) #11
Marijn Kruisselbrink
+michaeln for Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h OWNERS
5 years, 4 months ago (2015-07-29 23:59:51 UTC) #13
falken
driveby serviceworker lgtm
5 years, 4 months ago (2015-07-30 00:18:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205783004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1205783004/140001
5 years, 4 months ago (2015-07-30 00:20:00 UTC) #17
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199691
5 years, 4 months ago (2015-07-30 00:23:34 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:54:41 UTC) #19
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/48a8914ca0253b908f73d5b36118223fc7b06ff2

Powered by Google App Engine
This is Rietveld 408576698