Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1210603002: Add an analyzer method to flush resolved ASTs (for testing). (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an analyzer method to flush resolved ASTs (for testing). This should allow us to avoid referring to some private implementation details of analyzer from analysis server. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/160645fba65dc6e70208ac9b6f40ec6bf51507cb

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +11 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +19 lines, -7 lines 2 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 6 months ago (2015-06-24 16:42:19 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1210603002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1210603002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode1189 pkg/analyzer/lib/src/context/context.dart:1189: void test_flushResolvedUnit(Source source) { The non-task-model version of ...
5 years, 6 months ago (2015-06-24 16:56:58 UTC) #3
Paul Berry
https://codereview.chromium.org/1210603002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1210603002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode1189 pkg/analyzer/lib/src/context/context.dart:1189: void test_flushResolvedUnit(Source source) { On 2015/06/24 16:56:58, Brian Wilkerson ...
5 years, 6 months ago (2015-06-24 20:08:32 UTC) #4
Paul Berry
5 years, 6 months ago (2015-06-24 20:17:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
160645fba65dc6e70208ac9b6f40ec6bf51507cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698