Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1210573002: Alter shader code for soft light to avoid driver bug. (Closed)

Created:
5 years, 6 months ago by egdaniel
Modified:
5 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Alter shader code for soft light to avoid driver bug. On the n5 there seems to be an issue where negating a variable at the start of an equation doesn't work. Moving the negated variable to a subtract at the end works around the issue (as would multiplying by -1.0). The main bug was caused by the -DaCub in the else if block, but I also adjusted the else block to make sure the same issue doesn't appear there at some later date. BUG=chromium:502434 Committed: https://skia.googlesource.com/skia/+/724ae2823e1481e162b576ecfe8525a329c100d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
5 years, 6 months ago (2015-06-24 14:51:53 UTC) #2
bsalomon
On 2015/06/24 14:51:53, egdaniel wrote: lgtm
5 years, 6 months ago (2015-06-24 14:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210573002/1
5 years, 6 months ago (2015-06-24 15:01:27 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 15:14:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/724ae2823e1481e162b576ecfe8525a329c100d5

Powered by Google App Engine
This is Rietveld 408576698