ScriptContextSetTest should close the main frame before finishing the test

extensions/renderer/script_context_set_unittest.cc

Index: extensions/renderer/script_context_set_unittest.cc
diff --git a/extensions/renderer/script_context_set_unittest.cc b/extensions/renderer/script_context_set_unittest.cc
index 44da610fc9c5cd5c0525a56f47926cf8c9e6bf10..9d0a30e22a5a24b05470ce30cfb655558dbc79bf 100644
--- a/extensions/renderer/script_context_set_unittest.cc
+++ b/extensions/renderer/script_context_set_unittest.cc
@@ -12,6 +12,7 @@
 #include "extensions/renderer/script_context_set.h"
 #include "gin/public/context_holder.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/web/WebHeap.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "v8/include/v8.h"
@@ -60,6 +61,11 @@ TEST(ScriptContextSetTest, Lifecycle) {
   // After removal, the context should be marked for destruction.
   EXPECT_FALSE(context->is_valid());
 
+  webview->close();
+  frame->close();
+
+  blink::WebHeap::collectAllGarbageForTesting();

[not at google - send to devlin, 2015/06/24 16:08:47]

This will probably regress at some point in the future - or, the next test we
add which needs a frame will fail for similar and mysterious reasons.

If it's important to submit this CL right this second, then ok - but longer term
I'd really like to see a RAAI solution. For example, a file like
"extensions/renderer/scoped_web_frame":

class ScopedWebFrame {
 public:
  ScopedWebFrame() : view_(nullptr), frame_(nullptr) {
    view_ = WebView::Create(nullptr);
    frame_ = WebLocalFrame::create(...);
    view_->setMainFrame(frame);
  }

  ~ScopedWebFrame() {
    view_->close();
    frame_->close();
    WebHeap::collectAllGarbageForTesting();
  }

  WebLocalFrame* frame() { return frame_; }

 private:
  WebView* view_;
  WebLocalFrame* frame_;
};

then other tests can use that as well, *and* we have a canonical way of creating
test frames.

+
   // Run loop to do the actual deletion.
   loop.RunUntilIdle();
 }