ScriptContextSetTest should close the main frame before finishing the test

extensions/renderer/script_context_set_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/features/feature.h"
 #include "extensions/renderer/script_context.h"
 #include "extensions/renderer/script_context_set.h"
 #include "gin/public/context_holder.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/public/web/WebHeap.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "v8/include/v8.h"
 
 namespace extensions {
 
 TEST(ScriptContextSetTest, Lifecycle) {
   base::MessageLoop loop;
 
   blink::WebView* webview = blink::WebView::create(nullptr);
@@ skipping 28 matching lines @@
   EXPECT_EQ(context, context_set.GetByV8Context(v8_context));
 
   // Test context is correctly removed.
   context_set.Remove(context);
   EXPECT_EQ(0u, context_set.size());
   EXPECT_EQ(nullptr, context_set.GetByV8Context(v8_context));
 
   // After removal, the context should be marked for destruction.
   EXPECT_FALSE(context->is_valid());
 
+  webview->close();
+  frame->close();
+
+  blink::WebHeap::collectAllGarbageForTesting();

[not at google - send to devlin, 2015/06/24 16:08:47]

This will probably regress at some point in the future - or, the next test we
add which needs a frame will fail for similar and mysterious reasons.

If it's important to submit this CL right this second, then ok - but longer term
I'd really like to see a RAAI solution. For example, a file like
"extensions/renderer/scoped_web_frame":

class ScopedWebFrame {
 public:
  ScopedWebFrame() : view_(nullptr), frame_(nullptr) {
    view_ = WebView::Create(nullptr);
    frame_ = WebLocalFrame::create(...);
    view_->setMainFrame(frame);
  }

  ~ScopedWebFrame() {
    view_->close();
    frame_->close();
    WebHeap::collectAllGarbageForTesting();
  }

  WebLocalFrame* frame() { return frame_; }

 private:
  WebView* view_;
  WebLocalFrame* frame_;
};

then other tests can use that as well, *and* we have a canonical way of creating
test frames.

+
   // Run loop to do the actual deletion.
   loop.RunUntilIdle();
 }
 
 }  // namespace extensions