Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 121043005: Clean up virtual methods in MarkupAccumulator and subclasses (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
adamk
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up virtual methods in MarkupAccumulator and subclasses Clean up virtual methods in MarkupAccumulator and subclasses: - Use OVERRIDE for overriden virtual methods in StyledMarkupAccumulator and SerializerMarkupAccumulator - Mark StyledMarkupAccumulator and SerializerMarkupAccumulator and FINAL as these are never subclassed and they override several virtual methods. - MarkupAccumulator::appendString() does not need to be virtual as it does not need to be overriden R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164614

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/editing/MarkupAccumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +4 lines, -4 lines 2 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 11 months ago (2014-01-07 19:07:26 UTC) #1
adamk
https://codereview.chromium.org/121043005/diff/1/Source/core/editing/markup.cpp File Source/core/editing/markup.cpp (right): https://codereview.chromium.org/121043005/diff/1/Source/core/editing/markup.cpp#newcode121 Source/core/editing/markup.cpp:121: void appendString(const String& s) { return MarkupAccumulator::appendString(s); } Why ...
6 years, 11 months ago (2014-01-07 19:10:47 UTC) #2
Inactive
https://codereview.chromium.org/121043005/diff/1/Source/core/editing/markup.cpp File Source/core/editing/markup.cpp (right): https://codereview.chromium.org/121043005/diff/1/Source/core/editing/markup.cpp#newcode121 Source/core/editing/markup.cpp:121: void appendString(const String& s) { return MarkupAccumulator::appendString(s); } On ...
6 years, 11 months ago (2014-01-07 19:42:06 UTC) #3
adamk
lgtm
6 years, 11 months ago (2014-01-07 19:47:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/121043005/1
6 years, 11 months ago (2014-01-07 19:48:31 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 21:31:14 UTC) #6
Message was sent while issue was closed.
Change committed as 164614

Powered by Google App Engine
This is Rietveld 408576698