Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/page/PageSerializer.cpp

Issue 121043005: Clean up virtual methods in MarkupAccumulator and subclasses (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 { 92 {
93 return element->hasTagName(HTMLNames::scriptTag) || element->hasTagName(HTML Names::noscriptTag) || isCharsetSpecifyingNode(element); 93 return element->hasTagName(HTMLNames::scriptTag) || element->hasTagName(HTML Names::noscriptTag) || isCharsetSpecifyingNode(element);
94 } 94 }
95 95
96 static const QualifiedName& frameOwnerURLAttributeName(const HTMLFrameOwnerEleme nt& frameOwner) 96 static const QualifiedName& frameOwnerURLAttributeName(const HTMLFrameOwnerEleme nt& frameOwner)
97 { 97 {
98 // FIXME: We should support all frame owners including applets. 98 // FIXME: We should support all frame owners including applets.
99 return frameOwner.hasTagName(HTMLNames::objectTag) ? HTMLNames::dataAttr : H TMLNames::srcAttr; 99 return frameOwner.hasTagName(HTMLNames::objectTag) ? HTMLNames::dataAttr : H TMLNames::srcAttr;
100 } 100 }
101 101
102 class SerializerMarkupAccumulator : public WebCore::MarkupAccumulator { 102 class SerializerMarkupAccumulator FINAL : public MarkupAccumulator {
103 public: 103 public:
104 SerializerMarkupAccumulator(PageSerializer*, Document*, Vector<Node*>*); 104 SerializerMarkupAccumulator(PageSerializer*, Document*, Vector<Node*>*);
105 virtual ~SerializerMarkupAccumulator(); 105 virtual ~SerializerMarkupAccumulator();
106 106
107 protected: 107 protected:
108 virtual void appendText(StringBuilder& out, Text*); 108 virtual void appendText(StringBuilder& out, Text*) OVERRIDE;
109 virtual void appendElement(StringBuilder& out, Element*, Namespaces*); 109 virtual void appendElement(StringBuilder& out, Element*, Namespaces*) OVERRI DE;
110 virtual void appendCustomAttributes(StringBuilder& out, Element*, Namespaces *); 110 virtual void appendCustomAttributes(StringBuilder& out, Element*, Namespaces *) OVERRIDE;
111 virtual void appendEndTag(Node*); 111 virtual void appendEndTag(Node*) OVERRIDE;
112 112
113 private: 113 private:
114 PageSerializer* m_serializer; 114 PageSerializer* m_serializer;
115 Document* m_document; 115 Document* m_document;
116 }; 116 };
117 117
118 SerializerMarkupAccumulator::SerializerMarkupAccumulator(PageSerializer* seriali zer, Document* document, Vector<Node*>* nodes) 118 SerializerMarkupAccumulator::SerializerMarkupAccumulator(PageSerializer* seriali zer, Document* document, Vector<Node*>* nodes)
119 : MarkupAccumulator(nodes, ResolveAllURLs) 119 : MarkupAccumulator(nodes, ResolveAllURLs)
120 , m_serializer(serializer) 120 , m_serializer(serializer)
121 , m_document(document) 121 , m_document(document)
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 if (iter != m_blankFrameURLs.end()) 376 if (iter != m_blankFrameURLs.end())
377 return iter->value; 377 return iter->value;
378 String url = "wyciwyg://frame/" + String::number(m_blankFrameCounter++); 378 String url = "wyciwyg://frame/" + String::number(m_blankFrameCounter++);
379 KURL fakeURL(ParsedURLString, url); 379 KURL fakeURL(ParsedURLString, url);
380 m_blankFrameURLs.add(frame, fakeURL); 380 m_blankFrameURLs.add(frame, fakeURL);
381 381
382 return fakeURL; 382 return fakeURL;
383 } 383 }
384 384
385 } 385 }
OLDNEW
« Source/core/editing/markup.cpp ('K') | « Source/core/editing/markup.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698