Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Issue 1210393002: Revert of Debugger: use list to find shared function info in a script. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Debugger: use list to find shared function info in a script. (patchset #2 id:20001 of https://codereview.chromium.org/1206573004/) Reason for revert: [Sheriff] Breaks layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/682 Original issue's description: > Debugger: use list to find shared function info in a script. > > Now that we keep tabs on shared function infos from a script, we can speed up finding shared function infos for debugging. However, in case we have to compile a function that cannot be lazily compiled without context, we fall back to the slow heap iteration. > > R=mstarzinger@chromium.org > BUG=v8:4132, v8:4052 > LOG=N > > Committed: https://crrev.com/cfe89a71a332ef9ed481c8210bc3ad6d2822034b > Cr-Commit-Position: refs/heads/master@{#29296} TBR=mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4132, v8:4052 Committed: https://crrev.com/d350ab47f70a9810a28100bef7d98df84ff90755 Cr-Commit-Position: refs/heads/master@{#29312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -119 lines) Patch
M src/debug.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug.cc View 1 chunk +117 lines, -116 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Debugger: use list to find shared function info in a script.
5 years, 6 months ago (2015-06-26 08:20:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210393002/1
5 years, 6 months ago (2015-06-26 08:20:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 08:22:03 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 08:22:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d350ab47f70a9810a28100bef7d98df84ff90755
Cr-Commit-Position: refs/heads/master@{#29312}

Powered by Google App Engine
This is Rietveld 408576698