Debugger: use list to find shared function info in a script.

Debugger: use list to find shared function info in a script.

Now that we keep tabs on shared function infos from a script, we can speed up finding shared function infos for debugging. However, in case we have to compile a function that cannot be lazily compiled without context, we fall back to the slow heap iteration.

R=mstarzinger@chromium.org
BUG=v8:4132, v8:4052
LOG=N

Committed: https://crrev.com/cfe89a71a332ef9ed481c8210bc3ad6d2822034b
Cr-Commit-Position: refs/heads/master@{#29296}

Committed: https://crrev.com/058deb27132c97c62a99826455abc2bc87fae1b7
Cr-Commit-Position: refs/heads/master@{#29327}

[Michael Starzinger, 2015-06-25 10:33:39]

LGTM.

[Yang, 2015-06-25 14:00:16]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-06-25 14:00:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1206573004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-25 14:00:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206573004/20001

[commit-bot: I haz the power, 2015-06-25 14:27:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-25 14:27:50]

Patchset 2 (id:??) landed as
https://crrev.com/cfe89a71a332ef9ed481c8210bc3ad6d2822034b
Cr-Commit-Position: refs/heads/master@{#29296}

[Michael Achenbach, 2015-06-26 08:20:40]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1210393002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil....

[Yang, 2015-06-26 13:16:33]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[Yang, 2015-06-26 13:16:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1206573004/#ps40001
(title: "fix liveedit")

[commit-bot: I haz the power, 2015-06-26 13:16:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206573004/40001

[commit-bot: I haz the power, 2015-06-26 13:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-26 13:44:53]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-06-26 13:51:36]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-06-26 13:51:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206573004/40001

[commit-bot: I haz the power, 2015-06-26 13:53:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-26 13:53:43]

Patchset 3 (id:??) landed as
https://crrev.com/058deb27132c97c62a99826455abc2bc87fae1b7
Cr-Commit-Position: refs/heads/master@{#29327}

[brucedawson, 2015-06-29 17:08:52]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-06-29 17:08:53]

Three instances of potentially-confusing variable shadowing. Consider fixing?

https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc#newcode2064
src/debug.cc:2064: SharedFunctionInfo* shared = SharedFunctionInfo::cast(item);
Is it intentional that this shadows the outer-scope variable of the same name?
This is potentially confusing.

https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc#newcode2084
src/debug.cc:2084: JSFunction* closure = NULL;
Is it intentional that this shadows the outer-scope variable of the same name?
This is potentially confusing.

https://codereview.chromium.org/1206573004/diff/40001/src/debug.cc#newcode2085
src/debug.cc:2085: SharedFunctionInfo* shared = NULL;
Is it intentional that this shadows the outer-scope variable of the same name?
This is potentially confusing.