Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1210253006: Dart: Allows the mojom package's generate script to download .mojoms. (Closed)

Created:
5 years, 5 months ago by zra
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Allows the mojom package's generate script to download .mojoms. This change adds an option to generate.dart that causes it to look for files named '.mojoms' in a package. That file contains https:// URLs for .mojom files. The generate.dart script downloads the files and invokes Mojo's bindings generation on them. This change also fixes a but in Dart bindings generation, which caused a failure when generating only bindings for Dart. BUG= R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f92948b9155cb3429e69b12fdecbe479aa79bc7a

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 8

Patch Set 7 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -116 lines) Patch
M mojo/dart/mojom/lib/generate.dart View 1 2 3 4 5 6 8 chunks +134 lines, -79 lines 0 comments Download
A mojo/dart/mojom/lib/src/utils.dart View 1 chunk +100 lines, -0 lines 0 comments Download
M mojo/dart/mojom/test/generate_test.dart View 1 2 3 4 5 6 10 chunks +242 lines, -27 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +16 lines, -10 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zra
I'll be out for the next two weeks, so not urgent. Also feel free to ...
5 years, 5 months ago (2015-07-03 21:08:35 UTC) #2
Cutch
https://codereview.chromium.org/1210253006/diff/100001/mojo/dart/mojom/lib/generate.dart File mojo/dart/mojom/lib/generate.dart (right): https://codereview.chromium.org/1210253006/diff/100001/mojo/dart/mojom/lib/generate.dart#newcode102 mojo/dart/mojom/lib/generate.dart:102: /// mojom direcoty with the downloaded mojoms, creating the ...
5 years, 5 months ago (2015-07-20 15:39:09 UTC) #3
zra
https://codereview.chromium.org/1210253006/diff/100001/mojo/dart/mojom/lib/generate.dart File mojo/dart/mojom/lib/generate.dart (right): https://codereview.chromium.org/1210253006/diff/100001/mojo/dart/mojom/lib/generate.dart#newcode102 mojo/dart/mojom/lib/generate.dart:102: /// mojom direcoty with the downloaded mojoms, creating the ...
5 years, 5 months ago (2015-07-20 21:09:05 UTC) #4
Cutch
lgtm
5 years, 5 months ago (2015-07-20 21:11:53 UTC) #5
zra
5 years, 5 months ago (2015-07-20 22:43:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
f92948b9155cb3429e69b12fdecbe479aa79bc7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698