Issue 1210253005: Factor dart_init.cc out of dart_controller.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1210253005: Factor dart_init.cc out of dart_controller.cc (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Chinmay, eseidel1

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Factor dart_init.cc out of dart_controller.cc Also, remove the non-SkyView client of DartController to simplify the code further. R=chinmaygarde@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c27a4af2b99c8e240052b4e006cdd0e5a4953947

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -390 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/frame/LocalFrame.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	sky/engine/core/frame/LocalFrame.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	6 chunks	+25 lines, -187 lines	0 comments	Download
A	sky/engine/core/script/dart_init.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A +	sky/engine/core/script/dart_init.cc	View	8 chunks	+44 lines, -174 lines	0 comments	Download
M	sky/engine/public/sky/sky_view.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/web/Sky.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 5 months ago (2015-07-01 17:54:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c27a4af2b99c8e240052b4e006cdd0e5a4953947 (presubmit successful).