Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: sky/engine/core/frame/LocalFrame.cpp

Issue 1210253005: Factor dart_init.cc out of dart_controller.cc (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/LocalFrame.h ('k') | sky/engine/core/script/dart_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/LocalFrame.cpp
diff --git a/sky/engine/core/frame/LocalFrame.cpp b/sky/engine/core/frame/LocalFrame.cpp
index 5f28578dd82b2330979132c09d7a8e898daebb00..237b3e346990339d38e94fed711872a2a3654840 100644
--- a/sky/engine/core/frame/LocalFrame.cpp
+++ b/sky/engine/core/frame/LocalFrame.cpp
@@ -65,7 +65,6 @@ inline LocalFrame::LocalFrame(FrameLoaderClient* client, FrameHost* host)
: Frame(client, host)
, m_deprecatedLoader(this)
, m_mojoLoader(adoptPtr(new MojoLoader(*this)))
- , m_dart(adoptPtr(new DartController()))
, m_editor(Editor::create(*this))
, m_spellChecker(SpellChecker::create(*this))
, m_selection(FrameSelection::create(this))
@@ -122,10 +121,6 @@ void LocalFrame::detach()
setView(nullptr);
willDetachFrameHost();
- // Finish all cleanup work that might require talking to the embedder.
- // Notify ScriptController that the frame is closing, since its cleanup ends up calling
- // back to FrameLoaderClient via WindowProxy.
- dart().ClearForClose();
// After this, we must no longer talk to the client since this clears
// its owning reference back to our owning LocalFrame.
loaderClient()->detachedFromParent();
« no previous file with comments | « sky/engine/core/frame/LocalFrame.h ('k') | sky/engine/core/script/dart_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698