Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1210193002: [Telemetry] Remove usage of adb_commands in android_command_line_backend and android_browser_finder (Closed)

Created:
5 years, 6 months ago by nednguyen
Modified:
5 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove usage of adb_commands in android_command_line_backend and android_browser_finder BUG=476709 Committed: https://crrev.com/85ed89fcc2580d18a60f5ee49ba40f04a58296ef Cr-Commit-Position: refs/heads/master@{#336305}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Add Enabled('android') back #

Patch Set 3 : Fix indentation #

Patch Set 4 : Update android_browser_backend.py #

Patch Set 5 : Fix call in android_browser_backend #

Messages

Total messages: 16 (8 generated)
nednguyen
5 years, 6 months ago (2015-06-25 19:06:15 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/1210193002/diff/20001/tools/telemetry/telemetry/internal/backends/android_command_line_backend.py File tools/telemetry/telemetry/internal/backends/android_command_line_backend.py (right): https://codereview.chromium.org/1210193002/diff/20001/tools/telemetry/telemetry/internal/backends/android_command_line_backend.py#newcode110 tools/telemetry/telemetry/internal/backends/android_command_line_backend.py:110: as_root=True, check_return=True) nit: fix indentation
5 years, 6 months ago (2015-06-25 20:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210193002/60001
5 years, 6 months ago (2015-06-25 22:03:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/21803)
5 years, 6 months ago (2015-06-25 23:22:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210193002/60001
5 years, 6 months ago (2015-06-25 23:26:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210193002/100001
5 years, 6 months ago (2015-06-25 23:37:43 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 6 months ago (2015-06-26 01:04:48 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 01:05:41 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/85ed89fcc2580d18a60f5ee49ba40f04a58296ef
Cr-Commit-Position: refs/heads/master@{#336305}

Powered by Google App Engine
This is Rietveld 408576698