tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py - Issue 1210193002: [Telemetry] Remove usage of adb_commands in android_command_line_backend and android_browser_finder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

Issue 1210193002: [Telemetry] Remove usage of adb_commands in android_command_line_backend and android_browser_finder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix call in android_browser_backend Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/android_command_line_backend_unittest.py ('k') | tools/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

index 3cee5b688f87dac085e56f5f77b03b7eea1a2532..80ca15484c40426344af2b4dd63f0149fb70e9f4 100644

--- a/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

@@ -97,7 +97,7 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

browser_startup_args = self.GetBrowserStartupArgs()

with android_command_line_backend.SetUpCommandLineFlags(

- self._adb, self._backend_settings, browser_startup_args):

+ self._adb.device(), self._backend_settings, browser_startup_args):

self._adb.device().StartActivity(

intent.Intent(package=self._backend_settings.package,

activity=self._backend_settings.activity,