Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1210183005: Revert of Convert ui_base_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 6 months ago by Mike Wittman
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@5_midi_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert ui_base_unittests to run exclusively on Swarming (patchset #1 id:1 of https://codereview.chromium.org/1206413002/) Reason for revert: Suspecting this or https://codereview.chromium.org/1208103004 broke isolate step on Mac ASan 64. Reverting both CLs. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/21337 Original issue's description: > Convert ui_base_unittests to run exclusively on Swarming > > 8 configs already ran on Swarming > 21 used to run locally and were converted: > - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) > - chromium.chromiumos.json: Linux ChromiumOS Tests (1) > - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) > - chromium.fyi.json: CrWinAsan tester > - chromium.fyi.json: CrWinAsan(dll) tester > - chromium.fyi.json: Linux Trusty > - chromium.fyi.json: Linux Trusty (dbg) > - chromium.linux.json: Cast Linux > - chromium.memory.fyi.json: Linux ChromeOS MSan Tests > - chromium.memory.fyi.json: Linux MSan Tests > - chromium.memory.fyi.json: Linux TSan Tests > - chromium.memory.json: Linux ASan LSan Tests (1) > - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) > - chromium.memory.json: Mac ASan 64 Tests (1) > - chromium.webkit.json: Linux ChromiumOS Tests (1) > - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) > - chromium.win.json: Vista Tests (1) > - chromium.win.json: Win 7 Tests x64 (1) > - chromium.win.json: Win7 Tests (1) > - chromium.win.json: Win7 Tests (dbg)(1) > - chromium.win.json: XP Tests (1) > > Ran: > ./manage.py --convert ui_base_unittests > > R=dpranke@chromium.org > BUG=98637 > > Committed: https://crrev.com/dcb3f2e5539b9c92c28b675b2967d79127d6b73e > Cr-Commit-Position: refs/heads/master@{#336258} TBR=dpranke@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/1dc997d13f2858c65543ba3900e3fa460f4134ca Cr-Commit-Position: refs/heads/master@{#336277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -63 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
Created Revert of Convert ui_base_unittests to run exclusively on Swarming
5 years, 6 months ago (2015-06-25 22:31:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210183005/1
5 years, 6 months ago (2015-06-25 22:34:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 22:36:15 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 22:37:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dc997d13f2858c65543ba3900e3fa460f4134ca
Cr-Commit-Position: refs/heads/master@{#336277}

Powered by Google App Engine
This is Rietveld 408576698