Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1208103004: Convert midi_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 6 months ago by M-A Ruel
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@4_message_center_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert midi_unittests to run exclusively on Swarming 13 configs already ran on Swarming 16 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) Ran: ./manage.py --convert midi_unittests R=dpranke@chromium.org BUG=98637 Committed: https://crrev.com/fd955c285b8196938bd08767de2df019c7029a07 Cr-Commit-Position: refs/heads/master@{#336264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
M-A Ruel
5 years, 6 months ago (2015-06-25 18:59:57 UTC) #1
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-25 20:14:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208103004/1
5 years, 6 months ago (2015-06-25 20:26:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 21:40:37 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd955c285b8196938bd08767de2df019c7029a07 Cr-Commit-Position: refs/heads/master@{#336264}
5 years, 6 months ago (2015-06-25 21:41:56 UTC) #6
Mike Wittman
5 years, 6 months ago (2015-06-25 22:31:07 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1210933003/ by wittman@chromium.org.

The reason for reverting is: Suspecting this or
https://codereview.chromium.org/1206413002 broke isolate step on Mac ASan 64.
Reverting both CLs.

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Build....

Powered by Google App Engine
This is Rietveld 408576698