Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/resources/options/content_settings.html

Issue 1210173012: Split the Media settings UI into separate microphone and camera sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the policy indicator test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/content_settings.html
diff --git a/chrome/browser/resources/options/content_settings.html b/chrome/browser/resources/options/content_settings.html
index 251ad1212e4b3c603a6386597d8ecdbb9adffded..e8da4ae1f7085bfd7a873508500bb52146eff02e 100644
--- a/chrome/browser/resources/options/content_settings.html
+++ b/chrome/browser/resources/options/content_settings.html
@@ -393,13 +393,9 @@
</div>
</section>
</if>
- <!-- Media Stream capture device filter -->
- <section id="media-stream-settings">
- <div class="section-header">
- <h3 i18n-content="mediaStreamTabLabel"></h3>
- <span id="media-indicator"
- class="controlled-setting-indicator group-indicator"></span>
- </div>
+ <!-- Microphone filter -->
+ <section>
+ <h3 i18n-content="mediaStreamMicTabLabel">Microphone</h3>
Bernhard Bauer 2015/07/17 08:37:11 Remove the contents here.
msramek 2015/07/17 11:59:50 Done.
<div>
<div class="media-device-control">
<span id="media-select-mic-label" i18n-content="mediaSelectMicLabel">
@@ -407,6 +403,41 @@
<select id="media-select-mic" class="weakrtl"
aria-labelledby="media-select-mic-label"></select>
</div>
+ <div class="radio controlled-setting-with-label">
+ <label>
+ <input type="radio" name="media-stream-mic" value="ask">
+ <span>
+ <span i18n-content="mediaStreamMicAsk"></span>
+ <span class="controlled-setting-indicator"
+ content-setting="media-stream-mic" value="ask"></span>
+ </span>
+ </label>
+ </div>
+ <div class="radio controlled-setting-with-label">
+ <label>
+ <input type="radio" name="media-stream-mic" value="block">
+ <span>
+ <span i18n-content="mediaStreamMicBlock"></span>
+ <span class="controlled-setting-indicator"
+ content-setting="media-stream-mic" value="block"></span>
+ </span>
+ </label>
+ </div>
+ <div class="settings-row">
+ <button class="exceptions-list-button" contentType="media-stream-mic"
+ i18n-content="manageExceptions"></button>
+ </div>
+ <div id="media-pepper-flash-default" class="pepper-flash-settings">
+ <span i18n-content="mediaPepperFlashDefaultDivergedLabel"></span>
+ <a target="_blank" i18n-content="mediaPepperFlashChangeLink"
+ i18n-values="href:mediaPepperFlashGlobalPrivacyURL"></a>
+ </div>
+ </div>
+ </section>
+ <!-- Camera filter -->
+ <section>
+ <h3 i18n-content="mediaStreamCameraTabLabel">Camera</h3>
Bernhard Bauer 2015/07/17 08:37:11 Remove the contents here.
msramek 2015/07/17 11:59:49 Done.
+ <div>
<div class="media-device-control">
<span id="media-select-camera-label"
i18n-content="mediaSelectCameraLabel"></span>
@@ -415,30 +446,28 @@
</div>
<div class="radio controlled-setting-with-label">
<label>
- <input type="radio" name="media-stream" value="ask">
+ <input type="radio" name="media-stream-camera" value="ask">
<span>
- <span id="media-stream-ask-label" i18n-content="mediaStreamAsk">
- </span>
+ <span i18n-content="mediaStreamCameraAsk"></span>
<span class="controlled-setting-indicator"
- content-setting="media-stream" value="ask"></span>
+ content-setting="media-stream-camera" value="ask"></span>
</span>
</label>
</div>
<div class="radio controlled-setting-with-label">
<label>
- <input id="media-stream-block" type="radio" name="media-stream"
- value="block">
+ <input type="radio" name="media-stream-camera" value="block">
<span>
- <span id="media-stream-block-label"
- i18n-content="mediaStreamBlock"></span>
+ <span i18n-content="mediaStreamCameraBlock"></span>
<span class="controlled-setting-indicator"
- content-setting="media-stream" value="block"></span>
+ content-setting="media-stream-camera" value="block"></span>
</span>
</label>
</div>
<div class="settings-row">
- <button class="exceptions-list-button" contentType="media-stream"
- i18n-content="manageExceptions"></button>
+ <button class="exceptions-list-button"
+ contentType="media-stream-camera" i18n-content="manageExceptions">
+ </button>
</div>
<div id="media-pepper-flash-default" class="pepper-flash-settings">
<span i18n-content="mediaPepperFlashDefaultDivergedLabel"></span>

Powered by Google App Engine
This is Rietveld 408576698