Issue 1210153005: Remove custom material styling for EditText in preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1210153005: Remove custom material styling for EditText in preferences (Closed)

Created:
5 years, 5 months ago by Theresa

Modified:
5 years, 5 months ago

Reviewers:
aurimas (slooooooooow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

Remove custom material styling for EditText in preferences This is implemented in AppCompat now and our custom implementation was causing bugs (e.g. the cursor was showing up white). BUG=497608 TBR=aurimas@chromium.org Review URL: https://codereview.chromium.org/1169903003 Cr-Commit-Position: refs/heads/master@{#333762} Committed: https://chromium.googlesource.com/chromium/src/+/3af5faf74a73754b8f090453434a6c4b94d1f368

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -20 lines)			Patch
	D	chrome/android/java/res/color/edit_text_tint.xml	View		1 chunk	+0 lines, -15 lines	0 comments	Download
	M	chrome/android/java/res/values-v21/styles.xml	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)

Theresa

5 years, 5 months ago (2015-06-29 18:51:58 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3af5faf74a73754b8f090453434a6c4b94d1f368 (presubmit successful).