Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1169903003: Remove custom material styling for EditText in preferences (Closed)

Created:
5 years, 6 months ago by Theresa
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove custom material styling for EditText in preferences This is implemented in AppCompat now and our custom implementation was causing bugs (e.g. the cursor was showing up white). BUG=497608 Committed: https://crrev.com/4a23ee92305fa001c147f427605427904c774425 Cr-Commit-Position: refs/heads/master@{#333762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
D chrome/android/java/res/color/edit_text_tint.xml View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/android/java/res/values-v21/styles.xml View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Theresa
ptal
5 years, 6 months ago (2015-06-10 01:16:58 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 6 months ago (2015-06-10 01:18:56 UTC) #3
Theresa
+tedchoc for OWNERS
5 years, 6 months ago (2015-06-10 01:20:22 UTC) #5
Ted C
On 2015/06/10 01:20:22, Theresa Wellington wrote: > +tedchoc for OWNERS Aurimas is an owner, so ...
5 years, 6 months ago (2015-06-10 01:28:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169903003/1
5 years, 6 months ago (2015-06-10 17:42:57 UTC) #8
Theresa
On 2015/06/10 01:28:48, Ted C wrote: > On 2015/06/10 01:20:22, Theresa Wellington wrote: > > ...
5 years, 6 months ago (2015-06-10 17:43:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 18:20:11 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:21:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a23ee92305fa001c147f427605427904c774425
Cr-Commit-Position: refs/heads/master@{#333762}

Powered by Google App Engine
This is Rietveld 408576698