Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: testing/gtest.gyp

Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-unsequenced
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/secondary/testing/gtest/BUILD.gn ('K') | « sandbox/win/src/service_resolver.h ('k') | third_party/leveldatabase/env_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/gtest.gyp
diff --git a/testing/gtest.gyp b/testing/gtest.gyp
index d61772ecbe23323760e2a22a8364697bf88cbe29..16ce610873b047f530c3ceca6f2ca80da4b25a5a 100644
--- a/testing/gtest.gyp
+++ b/testing/gtest.gyp
@@ -191,6 +191,13 @@
],
'msvs_disabled_warnings': [4800],
},
+ 'variables': {
+ 'clang_warning_flags': [
+ # The Mutex constructor initializer list in gtest-port.cc is
+ # incorrectly ordered.
Nico 2015/06/30 18:03:50 Can you file an upstream bug for this and link to
Sam McNally 2015/07/02 00:12:13 Done.
+ '-Wno-reorder',
+ ]
+ },
},
{
'target_name': 'gtest_main',
« build/secondary/testing/gtest/BUILD.gn ('K') | « sandbox/win/src/service_resolver.h ('k') | third_party/leveldatabase/env_chromium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698