Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/secondary/testing/gtest/BUILD.gn

Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-unsequenced
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/app/chrome_watcher_client_unittest_win.cc » ('j') | testing/gtest.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/testing/gtest/BUILD.gn
diff --git a/build/secondary/testing/gtest/BUILD.gn b/build/secondary/testing/gtest/BUILD.gn
index a20a09d4db6470ea5534096c1822e27a24fb3478..a2d7369285cc557ca6da7cb717f6baac60edaf61 100644
--- a/build/secondary/testing/gtest/BUILD.gn
+++ b/build/secondary/testing/gtest/BUILD.gn
@@ -22,6 +22,11 @@ config("gtest_config") {
if (is_win) {
cflags = [ "/wd4800" ] # Unused variable warning.
+ if (is_clang) {
+ # The Mutex constructor initializer list in gtest-port.cc is incorrectly
+ # ordered.
Nico 2015/06/30 18:03:50 Can you file an upstream bug for this?
Sam McNally 2015/07/02 00:12:13 Done.
+ cflags += [ "-Wno-reorder" ]
+ }
}
if (is_posix) {
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/app/chrome_watcher_client_unittest_win.cc » ('j') | testing/gtest.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698