cloud_print/service/win/chrome_launcher.cc - Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/chrome_launcher.cc

Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-unsequenced

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cloud_print/service/win/chrome_launcher.cc

diff --git a/cloud_print/service/win/chrome_launcher.cc b/cloud_print/service/win/chrome_launcher.cc

index e9bcee10f055ebcc3b6b5d01be70075fcb12e8ad..8c005566d01b25957bf88de7830bd10a0c6fc81a 100644

--- a/cloud_print/service/win/chrome_launcher.cc

+++ b/cloud_print/service/win/chrome_launcher.cc

@@ -173,8 +173,7 @@ void DeleteAutorunKeys(const base::FilePath& user_data_dir) {

} // namespace

ChromeLauncher::ChromeLauncher(const base::FilePath& user_data)

- : stop_event_(true, true),

- user_data_(user_data) {

+ : user_data_(user_data), stop_event_(true, true) {

}

ChromeLauncher::~ChromeLauncher() {

« build/secondary/testing/gtest/BUILD.gn ('K') | « chrome/installer/util/set_reg_value_work_item.cc ('k') | cloud_print/service/win/service.gyp » ('j') | testing/gtest.gyp » ('J')