Fixes case where terminator instruction is missing at end of function.

Fixes case where terminator instruction is missing at end of function.

If the bitcode parser detects that the last block in the function
is missing a terminator, generate an error message and insert
a terminator instruction.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4214
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6c17dd8cb9b7b62b872ce4fd49d61b5f646f4899

[Karl, 2015-06-29 20:33:14]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-06-29 22:43:13]

lgtm

https://codereview.chromium.org/1210013005/diff/20001/pydir/run-pnacl-sz.py
File pydir/run-pnacl-sz.py (right):

https://codereview.chromium.org/1210013005/diff/20001/pydir/run-pnacl-sz.py#n...
pydir/run-pnacl-sz.py:83: argparser.add_argument('--fail', required=False,
action='store_true',
Bikeshedding: how about something like '--expect-fail'?

https://codereview.chromium.org/1210013005/diff/20001/pydir/run-pnacl-sz.py#n...
pydir/run-pnacl-sz.py:101: raise RuntimeError("Can't specify '--tbc' and
'--llvm-source'")
"Can't specify both ..." for consistency?

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/lit.cfg
File tests_lit/lit.cfg (right):

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/lit.cfg#newco...
tests_lit/lit.cfg:109: pnaclbintools = [r"\bFileCheck\b",
Maybe it's time to rewrite this clumsy array, something like:

pnaclbintools = [r'\b' + x + r'\b' for x in
  ['FileCheck', 'le32-nacl-objdump', 'llvm-as', 'llvm-mc', 'llvm-readobj',
   'not', 'pnacl-bcfuzz', 'pnacl-freeze', 'pnacl-bcdis']]

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/invalid.test (right):

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/invalid.test:1: ; Test that we handle functions that
don't end with terminator instruction.
with a terminator

[Karl, 2015-06-30 17:25:32]

Committed patchset #3 (id:40001) manually as
6c17dd8cb9b7b62b872ce4fd49d61b5f646f4899 (presubmit successful).

[Karl, 2015-06-30 18:46:09]

https://codereview.chromium.org/1210013005/diff/20001/pydir/run-pnacl-sz.py
File pydir/run-pnacl-sz.py (right):

https://codereview.chromium.org/1210013005/diff/20001/pydir/run-pnacl-sz.py#n...
pydir/run-pnacl-sz.py:83: argparser.add_argument('--fail', required=False,
action='store_true',
On 2015/06/29 22:43:12, stichnot wrote:
> Bikeshedding: how about something like '--expect-fail'?

Done.

https://codereview.chromium.org/1210013005/diff/20001/pydir/run-pnacl-sz.py#n...
pydir/run-pnacl-sz.py:101: raise RuntimeError("Can't specify '--tbc' and
'--llvm-source'")
On 2015/06/29 22:43:12, stichnot wrote:
> "Can't specify both ..." for consistency?

Done.

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/lit.cfg
File tests_lit/lit.cfg (right):

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/lit.cfg#newco...
tests_lit/lit.cfg:109: pnaclbintools = [r"\bFileCheck\b",
On 2015/06/29 22:43:12, stichnot wrote:
> Maybe it's time to rewrite this clumsy array, something like:
> 
> pnaclbintools = [r'\b' + x + r'\b' for x in
>   ['FileCheck', 'le32-nacl-objdump', 'llvm-as', 'llvm-mc', 'llvm-readobj',
>    'not', 'pnacl-bcfuzz', 'pnacl-freeze', 'pnacl-bcdis']]

Done.

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/llvm2ice_test...
File tests_lit/llvm2ice_tests/invalid.test (right):

https://codereview.chromium.org/1210013005/diff/20001/tests_lit/llvm2ice_test...
tests_lit/llvm2ice_tests/invalid.test:1: ; Test that we handle functions that
don't end with terminator instruction.
On 2015/06/29 22:43:12, stichnot wrote:
> with a terminator

Done.