Fixes case where terminator instruction is missing at end of function.

tests_lit/lit.cfg

 # -*- Python -*-
 # Taken from utils/lit/tests in the LLVM tree and hacked together to support
 # our tests.
 #
 # Note: This configuration has simple commands to run Subzero's translator.
 # They have the form %X2i (i.e. %p2i, %l2i, and %lc2i) where X is defined
 # as follows:
 #
 #   p : Run Subzero's translator, building ICE from PNaCl bitcode directly.
 #   l : Run Subzero's translator, converting the .ll file to a PNaCl bitcode
@@ skipping 30 matching lines @@
 sys.path.insert(0, 'pydir')
 from utils import FindBaseNaCl, shellcmd
 
 # name: The name of this test suite.
 config.name = 'subzero'
 
 # testFormat: The test format to use to interpret tests.
 config.test_format = lit.formats.ShTest()
 
 # suffixes: A list of file extensions to treat as test files.
-config.suffixes = ['.ll']
+config.suffixes = ['.ll', '.test']
 
 # test_source_root: The root path where tests are located.
 config.test_source_root = os.path.dirname(__file__)
 config.test_exec_root = config.test_source_root
 config.target_triple = '(unused)'
 
 src_root = os.path.join(FindBaseNaCl(), 'toolchain_build/src/subzero')
 bin_root = src_root
 config.substitutions.append(('%{src_root}', src_root))
 config.substitutions.append(('%{python}', sys.executable))
@@ skipping 37 matching lines @@
 
 # Translate LLVM source for each compiler setup.
 config.substitutions.append(('%p2i', ' '.join(pnacl_sz_cmd)))
 config.substitutions.append(('%l2i', ' '.join(ifl2i_atts_cmd + pnacl_sz_cmd
                                               + ['--llvm'])))
 config.substitutions.append(('%lc2i', ' '.join(iflc2i_atts_cmd + pnacl_sz_cmd
                                                + ['--llvm-source'])))
 
 config.substitutions.append(('%pnacl_sz', pnacl_sz_tool))
 
 pnaclbintools = [r"\bFileCheck\b",

[Jim Stichnoth, 2015/06/29 22:43:12]

Maybe it's time to rewrite this clumsy array, something like:

pnaclbintools = [r'\b' + x + r'\b' for x in
  ['FileCheck', 'le32-nacl-objdump', 'llvm-as', 'llvm-mc', 'llvm-readobj',
   'not', 'pnacl-bcfuzz', 'pnacl-freeze', 'pnacl-bcdis']]

[Karl, 2015/06/30 18:46:09]

Done.

                  r"\ble32-nacl-objdump\b",
                  r"\bllvm-as\b",
                  r"\bllvm-mc\b",
                  r"\bllvm-readobj\b",
                  r"\bnot\b",
+                 r"\bpnacl-bcfuzz\b",
                  r"\bpnacl-freeze\b",
                  r"\bpnacl-bcdis\b"]
 
 for tool in pnaclbintools:
   # The re.sub() line is adapted from one of LLVM's lit.cfg files.
   # Extract the tool name from the pattern.  This relies on the tool
   # name being surrounded by \b word match operators.  If the
   # pattern starts with "| ", include it in the string to be
   # substituted.
   substitution = re.sub(r"^(\\)?((\| )?)\W+b([0-9A-Za-z-_]+)\\b\W*$",
                         r"\2" + pnaclbinpath + "/" + r"\4",
                         tool)
   config.substitutions.append((tool, substitution))
 
 # Add a feature to detect the Python version.
 config.available_features.add("python%d.%d" % (sys.version_info[0],
                                                sys.version_info[1]))
 
 # Debugging output
 def dbg(s):
   print '[DBG] %s' % s
 
 dbg('bin_root = %s' % bin_root)
 dbg('pnaclbinpath = %s' % pnaclbinpath)
 dbg("Build attributes = %s" % pnacl_sz_atts)