Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Unified Diff: Source/modules/credentialmanager/Credential.cpp

Issue 1209953002: Rename avatarURL to iconURL in the credential manager in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/Credential.cpp
diff --git a/Source/modules/credentialmanager/Credential.cpp b/Source/modules/credentialmanager/Credential.cpp
index ba27650ab2356c5a89808861b1650ac09c61f3a1..b865e122ebe1d0864ad55cd43d53a5d21c6aa43e 100644
--- a/Source/modules/credentialmanager/Credential.cpp
+++ b/Source/modules/credentialmanager/Credential.cpp
@@ -10,17 +10,17 @@
namespace blink {
-Credential* Credential::create(const String& id, const String& name, const KURL& avatar)
+Credential* Credential::create(const String& id, const String& name, const KURL& icon)
{
- return new Credential(id, name, avatar);
+ return new Credential(id, name, icon);
}
-Credential* Credential::create(const String& id, const String& name, const String& avatar, ExceptionState& exceptionState)
+Credential* Credential::create(const String& id, const String& name, const String& icon, ExceptionState& exceptionState)
{
- KURL avatarURL = parseStringAsURL(avatar, exceptionState);
+ KURL iconURL = parseStringAsURL(icon, exceptionState);
if (exceptionState.hadException())
return nullptr;
- return new Credential(id, name, avatarURL);
+ return new Credential(id, name, iconURL);
}
Credential::Credential(PlatformCredential* credential)
@@ -28,8 +28,8 @@ Credential::Credential(PlatformCredential* credential)
{
}
-Credential::Credential(const String& id, const String& name, const KURL& avatar)
- : m_platformCredential(PlatformCredential::create(id, name, avatar))
+Credential::Credential(const String& id, const String& name, const KURL& icon)
+ : m_platformCredential(PlatformCredential::create(id, name, icon))
{
}

Powered by Google App Engine
This is Rietveld 408576698