ServiceWorkerClients::openWindow() should reject with TypeError for an invalid URL.

ServiceWorkerClients::openWindow() should reject with TypeError for an invalid URL.

As per https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#clients-openwindow
Clients.openWindow() should throw TypeError instead of SyntaxError for an Invalid URL.

BUG=506071
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198127

[Paritosh Kumar, 2015-06-25 13:13:11]

paritosh.in@samsung.com changed reviewers:
+ falken@chromium.org, nhiroki@chromium.org

[Paritosh Kumar, 2015-06-25 13:13:11]

As the spec looks changing to allow about:blank after all:
https://github.com/slightlyoff/ServiceWorker/issues/699

Made this cl as separate for throwing TypeError for invalid URL in
ServiceWorkerClients::openWindow().

PTAL.

[nhiroki, 2015-07-01 06:56:39]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-01 06:56:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209933003/20001

[nhiroki, 2015-07-01 07:00:29]

Looks good to me. Could you file an issue for this and update the BUG= line?

https://codereview.chromium.org/1209933003/diff/20001/LayoutTests/http/tests/...
File
LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js
(right):

https://codereview.chromium.org/1209933003/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js:67:
self.postMessage('openWindow() can not open invalid url');
nit: "invalid" -> "an invalid"

[Paritosh Kumar, 2015-07-01 07:43:19]

Thanks nhiroki

Updated the cl description with newly created issue and updated cl to address
nit. Please have a look.

https://codereview.chromium.org/1209933003/diff/20001/LayoutTests/http/tests/...
File
LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js
(right):

https://codereview.chromium.org/1209933003/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js:67:
self.postMessage('openWindow() can not open invalid url');
On 2015/07/01 07:00:29, nhiroki wrote:
> nit: "invalid" -> "an invalid"

Thanks. Done.

[nhiroki, 2015-07-01 07:46:25]

LGTM!

[Paritosh Kumar, 2015-07-01 08:39:43]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2015-07-01 08:40:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209933003/40001

[commit-bot: I haz the power, 2015-07-01 10:25:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198127