Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html

Issue 1209933003: ServiceWorkerClients::openWindow() should reject with TypeError for an invalid URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <title>Service Worker: clients.openWindow() tests (using testRunner)</title> 2 <title>Service Worker: clients.openWindow() tests (using testRunner)</title>
3 <script src="../../resources/testharness.js"></script> 3 <script src="../../resources/testharness.js"></script>
4 <script src="../../resources/testharnessreport.js"></script> 4 <script src="../../resources/testharnessreport.js"></script>
5 <script src="../resources/test-helpers.js"></script> 5 <script src="../resources/test-helpers.js"></script>
6 <script> 6 <script>
7 // This test is using testRunner to grant itself the notification permission and 7 // This test is using testRunner to grant itself the notification permission and
8 // to simulate a click on a notification. A couple of changes would allow it to 8 // to simulate a click on a notification. A couple of changes would allow it to
9 // be run as a manual test by other browser vendors. 9 // be run as a manual test by other browser vendors.
10 if (window.testRunner) 10 if (window.testRunner)
(...skipping 25 matching lines...) Expand all
36 'openWindow() can open controlled windows', 36 'openWindow() can open controlled windows',
37 'openWindow() result: [object WindowClient]', 37 'openWindow() result: [object WindowClient]',
38 ' url: ' + location.origin + '/serviceworker/chromium/resour ces/blank.html', 38 ' url: ' + location.origin + '/serviceworker/chromium/resour ces/blank.html',
39 ' visibilityState: visible', 39 ' visibilityState: visible',
40 ' focused: true', 40 ' focused: true',
41 ' frameType: top-level', 41 ' frameType: top-level',
42 'openWindow() can open about:blank', 42 'openWindow() can open about:blank',
43 'openWindow() result: null', 43 'openWindow() result: null',
44 'openWindow() can open about:crash', 44 'openWindow() can open about:crash',
45 'openWindow() result: null', 45 'openWindow() result: null',
46 'openWindow() can not open an invalid url',
47 'openWindow() error is: TypeError',
46 'openWindow() can not open view-source scheme', 48 'openWindow() can not open view-source scheme',
47 'openWindow() can not open file scheme', 49 'openWindow() can not open file scheme',
48 'openWindow() error is: SecurityError', 50 'openWindow() error is: SecurityError',
49 ]; 51 ];
50 52
51 // LayoutTests on Mac do not open focused windows. 53 // LayoutTests on Mac do not open focused windows.
52 var isMac = navigator.platform.indexOf('Mac') == 0; 54 var isMac = navigator.platform.indexOf('Mac') == 0;
53 if (isMac) 55 if (isMac)
54 expected[10] = ' focused: false'; 56 expected[10] = ' focused: false';
55 57
(...skipping 11 matching lines...) Expand all
67 if (message === 'quit') { 69 if (message === 'quit') {
68 assert_array_equals(result, expected, 70 assert_array_equals(result, expected,
69 'Worker should post back expected messages.'); 71 'Worker should post back expected messages.');
70 service_worker_unregister_and_done(t, scope); 72 service_worker_unregister_and_done(t, scope);
71 } else { 73 } else {
72 result.push(message); 74 result.push(message);
73 } 75 }
74 } 76 }
75 }); 77 });
76 </script> 78 </script>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698