Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: ui/aura/window_tree_host.cc

Issue 1209913002: InputMethod should stop TextInputClient::InsertChar/InsertText calls when the event is stopped prop… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/ime/input_method_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window_tree_host.cc
diff --git a/ui/aura/window_tree_host.cc b/ui/aura/window_tree_host.cc
index 2beb0ea19d8992f57ef1ce44e43caa6b64a3cee7..6fa987806790594862f6fdafd5ff744ee892e477 100644
--- a/ui/aura/window_tree_host.cc
+++ b/ui/aura/window_tree_host.cc
@@ -202,7 +202,7 @@ bool WindowTreeHost::DispatchKeyEventPostIME(const ui::KeyEvent& event) {
ui::EventDispatchDetails details =
event_processor()->OnEventFromSource(&copied_event);
DCHECK(!details.dispatcher_destroyed);
- return copied_event.handled();
+ return copied_event.stopped_propagation();
James Su 2015/06/25 13:38:23 And we can return ui::EventDispatchDetails. Above
Shu Chen 2015/06/26 02:05:20 Ditto.
sadrul 2015/06/27 03:06:28 Can you please add a TODO here for both of these (
Shu Chen 2015/06/27 09:43:56 The TODO has already been added in the DeliverEven
}
void WindowTreeHost::Show() {
« no previous file with comments | « no previous file | ui/base/ime/input_method_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698