InputMethod should stop TextInputClient::InsertChar/InsertText calls when the event is stopped prop…

ui/aura/window_tree_host.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window_tree_host.h"
 
 #include "base/thread_task_runner_handle.h"
 #include "base/trace_event/trace_event.h"
 #include "ui/aura/client/capture_client.h"
 #include "ui/aura/client/cursor_client.h"
@@ skipping 179 matching lines @@
   }
   return input_method_;
 }
 
 void WindowTreeHost::SetSharedInputMethod(ui::InputMethod* input_method) {
   DCHECK(!input_method_);
   input_method_ = input_method;
   owned_input_method_ = false;
 }
 
 bool WindowTreeHost::DispatchKeyEventPostIME(const ui::KeyEvent& event) {

[James Su, 2015/06/25 13:38:23]

I'd still prefer to change this method parameter to ui::KeyEvent*. 

[Shu Chen, 2015/06/26 02:05:20]

This can be a separated cl. Let's keep the cl as small as possible.

   ui::KeyEvent copied_event(event);
   ui::EventDispatchDetails details =
       event_processor()->OnEventFromSource(&copied_event);
   DCHECK(!details.dispatcher_destroyed);
-  return copied_event.handled();
+  return copied_event.stopped_propagation();

[James Su, 2015/06/25 13:38:23]

And we can return ui::EventDispatchDetails. Above DCHECK can also be removed.

[Shu Chen, 2015/06/26 02:05:20]

Ditto.

[sadrul, 2015/06/27 03:06:28]

Can you please add a TODO here for both of these (and maybe file a bug and
reference that from the comment here)? Thanks.

[Shu Chen, 2015/06/27 09:43:56]

The TODO has already been added in the DeliverEventToProcessor() method.

 }
 
 void WindowTreeHost::Show() {
   if (compositor())
     compositor()->SetVisible(true);
   ShowImpl();
 }
 
 void WindowTreeHost::Hide() {
   HideImpl();
@@ skipping 118 matching lines @@
   client::CursorClient* cursor_client = client::GetCursorClient(window());
   if (cursor_client) {
     const gfx::Display& display =
         gfx::Screen::GetScreenFor(window())->GetDisplayNearestWindow(window());
     cursor_client->SetDisplay(display);
   }
   dispatcher()->OnCursorMovedToRootLocation(root_location);
 }
 
 }  // namespace aura