Issue 1209713003: jsmin.py: Fix issue with escaping of back ticks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1209713003: jsmin.py: Fix issue with escaping of back ticks (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)

Modified:
5 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

jsmin.py: Fix issue with escaping of back ticks The escaping of back ticks in template strings was incorrect BUG=v8:4240 LOG=N TBR=yangguo@chromium.org Committed: https://crrev.com/a0f4706e5ea0ffaf0fbd1e0015a1a8697427f021 Cr-Commit-Position: refs/heads/master@{#29271}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/jsmin.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713003/1

5 years, 6 months ago (2015-06-24 22:00:55 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/a0f4706e5ea0ffaf0fbd1e0015a1a8697427f021 Cr-Commit-Position: refs/heads/master@{#29271}

5 years, 6 months ago (2015-06-24 22:29:55 UTC) #4

Yang

5 years, 6 months ago (2015-06-25 05:58:31 UTC) #5

Message was sent while issue was closed.

On 2015/06/24 22:29:55, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a0f4706e5ea0ffaf0fbd1e0015a1a8697427f021
> Cr-Commit-Position: refs/heads/master@{#29271}

lgtm. thank you.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages