tools/jsmin.py - Issue 1209713003: jsmin.py: Fix issue with escaping of back ticks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/jsmin.py

Issue 1209713003: jsmin.py: Fix issue with escaping of back ticks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/jsmin.py

diff --git a/tools/jsmin.py b/tools/jsmin.py

index cadc98b25897b30441236f790169adf4debe7d4d..236f511d447b228e9b5473dddba99fb93902397e 100644

--- a/tools/jsmin.py

+++ b/tools/jsmin.py

@@ -241,7 +241,7 @@ class JavaScriptMinifier(object):

# A regexp that matches a literal string surrounded by 'single quotes'.

single_quoted_string = r"'(?:[^'\\]|\\.)*'"

# A regexp that matches a template string

- template_string = r"`(?:[^'\\]|\\.)*`"

+ template_string = r"`(?:[^`\\]|\\.)*`"

# A regexp that matches a regexp literal surrounded by /slashes/.

# Don't allow a regexp to have a ) before the first ( since that's a

# syntax error and it's probably just two unrelated slashes.

« no previous file with comments | « no previous file | no next file » | no next file with comments »