Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1209713002: [Android] Use WebContents text manipulation methods directly (Closed)

Created:
5 years, 5 months ago by jdduke (slow)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Use WebContents text manipulation methods directly Rather than using ImeAdapter as a middleman for text-related actions, use WebContents directly where the actions are implemented. BUG=468806 Committed: https://crrev.com/c9c74e76750d156cfc8588bce680067e83169702 Cr-Commit-Position: refs/heads/master@{#336407}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -129 lines) Patch
M content/browser/renderer_host/ime_adapter_android.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 6 chunks +31 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 2 1 chunk +1 line, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 2 4 chunks +12 lines, -55 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 2 chunks +34 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +25 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ClipboardTest.java View 3 chunks +8 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
jdduke (slow)
aurimas@: PTAL. This will make a few things I need to support for mouse context ...
5 years, 5 months ago (2015-06-24 19:32:11 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 5 months ago (2015-06-24 20:07:21 UTC) #3
jdduke (slow)
+tedchoc for content/public/.../content_public and content/browser/web_contents
5 years, 5 months ago (2015-06-24 20:32:15 UTC) #5
Ted C
lgtm
5 years, 5 months ago (2015-06-24 23:17:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713002/1
5 years, 5 months ago (2015-06-24 23:37:40 UTC) #8
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-24 23:49:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713002/20001
5 years, 5 months ago (2015-06-25 17:34:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/38041)
5 years, 5 months ago (2015-06-25 19:53:21 UTC) #15
jdduke (slow)
On 2015/06/25 19:53:21, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-06-25 21:02:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713002/20001
5 years, 5 months ago (2015-06-25 21:21:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713002/40001
5 years, 5 months ago (2015-06-25 22:25:02 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/38233)
5 years, 5 months ago (2015-06-26 00:37:52 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713002/60001
5 years, 5 months ago (2015-06-26 16:58:09 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209713002/80001
5 years, 5 months ago (2015-06-26 17:01:06 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 5 months ago (2015-06-26 18:00:49 UTC) #33
commit-bot: I haz the power
5 years, 5 months ago (2015-06-26 18:01:39 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9c74e76750d156cfc8588bce680067e83169702
Cr-Commit-Position: refs/heads/master@{#336407}

Powered by Google App Engine
This is Rietveld 408576698