Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 1209713002: [Android] Use WebContents text manipulation methods directly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix null check Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
index fc31ad9f25061dd5ab2519c81bfebdde6bb85d96..ce3f2a169f737c68032213ff39a2dfc92027e404 100644
--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
@@ -166,6 +166,35 @@ import java.util.UUID;
}
@Override
+ public void cut() {
+ nativeCut(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public void copy() {
+ nativeCopy(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public void paste() {
+ nativePaste(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public void selectAll() {
+ nativeSelectAll(mNativeWebContentsAndroid);
+ }
+
+ @Override
+ public void unselect() {
+ // Unselect may get triggered when certain selection-related widgets
+ // are destroyed. As the timing for such destruction is unpredictable,
+ // safely guard against this case.
+ if (mNativeWebContentsAndroid == 0) return;
+ nativeUnselect(mNativeWebContentsAndroid);
+ }
+
+ @Override
public void insertCSS(String css) {
if (mNativeWebContentsAndroid == 0) return;
nativeInsertCSS(mNativeWebContentsAndroid, css);
@@ -346,6 +375,11 @@ import java.util.UUID;
private native boolean nativeIsLoading(long nativeWebContentsAndroid);
private native boolean nativeIsLoadingToDifferentDocument(long nativeWebContentsAndroid);
private native void nativeStop(long nativeWebContentsAndroid);
+ private native void nativeCut(long nativeWebContentsAndroid);
+ private native void nativeCopy(long nativeWebContentsAndroid);
+ private native void nativePaste(long nativeWebContentsAndroid);
+ private native void nativeSelectAll(long nativeWebContentsAndroid);
+ private native void nativeUnselect(long nativeWebContentsAndroid);
private native void nativeInsertCSS(long nativeWebContentsAndroid, String css);
private native void nativeOnHide(long nativeWebContentsAndroid);
private native void nativeOnShow(long nativeWebContentsAndroid);

Powered by Google App Engine
This is Rietveld 408576698