Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1209663002: Use EventHandler for IME (Closed)

Created:
5 years, 6 months ago by oshima
Modified:
5 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, Shu Chen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EventHandler for IME so that it honeres EventTargeter/EventHandlers. This also moves the InputEventEventHandler to early stage. This is so that KeyHoldDetectorss won't recieve events twice. InputMethodEventHandler skips sending to IME when * event was posted via DispatchKeyEventPostIME * or event is synthesized. This is necessary for software keyboard. We can't simply rely on synthesized mask because there key_hold_detector also generates key event. BUG=502113 Committed: https://crrev.com/5e0fff892917abdbbb1f8be7441c6b8179c83f40 Cr-Commit-Position: refs/heads/master@{#336487}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : uploaded correct CL #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -8 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/accelerators/magnifier_key_scroller_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/display_controller.h View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M ash/display/display_controller.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ash/host/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/host/ash_remote_window_tree_host_win.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M ash/host/ash_remote_window_tree_host_win.cc View 1 2 3 4 5 2 chunks +15 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 2 chunks +15 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_ozone.cc View 2 3 chunks +18 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_unified.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_unified.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 2 chunks +14 lines, -0 lines 0 comments Download
A ash/ime/input_method_event_handler.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A ash/ime/input_method_event_handler.cc View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 3 3 chunks +4 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 43 (20 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/1
5 years, 6 months ago (2015-06-24 18:00:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/20001
5 years, 6 months ago (2015-06-24 18:32:11 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/31781)
5 years, 6 months ago (2015-06-24 19:16:21 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/40001
5 years, 6 months ago (2015-06-25 20:40:18 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/32435)
5 years, 6 months ago (2015-06-25 21:23:03 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/80001
5 years, 6 months ago (2015-06-25 23:20:38 UTC) #18
oshima
I'd like to land this for 45. We can work on better solution after branch ...
5 years, 6 months ago (2015-06-25 23:24:08 UTC) #19
oshima
fyi: +shuchen, suzhe
5 years, 6 months ago (2015-06-25 23:26:32 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/100001
5 years, 6 months ago (2015-06-25 23:27:19 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/32538)
5 years, 6 months ago (2015-06-26 00:07:14 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/120001
5 years, 6 months ago (2015-06-26 00:12:56 UTC) #26
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-26 01:31:30 UTC) #28
sadrul
The windows trybot failures look relevant. Mind taking a look?
5 years, 6 months ago (2015-06-26 15:58:49 UTC) #29
James Su
Two questions: 1. Besides IME itself, which components will generate key events with EF_IS_SYNTHESIZED flag? ...
5 years, 6 months ago (2015-06-26 16:33:58 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/140001
5 years, 6 months ago (2015-06-26 19:34:40 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/160001
5 years, 6 months ago (2015-06-26 19:48:15 UTC) #34
oshima
On 2015/06/26 15:58:49, sadrul wrote: > The windows trybot failures look relevant. Mind taking a ...
5 years, 6 months ago (2015-06-26 20:10:10 UTC) #35
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-26 20:44:42 UTC) #37
oshima
On 2015/06/26 16:33:58, James Su wrote: > Two questions: > > 1. Besides IME itself, ...
5 years, 6 months ago (2015-06-26 21:22:16 UTC) #38
sadrul
lgtm for now. We should revisit for a better fix.
5 years, 5 months ago (2015-06-27 01:23:52 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209663002/160001
5 years, 5 months ago (2015-06-27 01:26:32 UTC) #41
commit-bot: I haz the power
Committed patchset #6 (id:160001)
5 years, 5 months ago (2015-06-27 01:31:40 UTC) #42
commit-bot: I haz the power
5 years, 5 months ago (2015-06-27 01:32:33 UTC) #43
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5e0fff892917abdbbb1f8be7441c6b8179c83f40
Cr-Commit-Position: refs/heads/master@{#336487}

Powered by Google App Engine
This is Rietveld 408576698