Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 12096116: Enable dictionary sync by default (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove experiment from about flags Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/sync/test/integration/dictionary_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
index 48207449510ab599c2173ac213821aee9461f5f3..eb64a02e6ad170d63928ed1737190fd21e452b41 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -235,12 +235,13 @@ void ProfileSyncComponentsFactoryImpl::RegisterDesktopDataTypes(
syncer::HISTORY_DELETE_DIRECTIVES, this, profile_, pss));
}
- // Dictionary sync is disabled by default. Register only if explicitly
- // enabled.
- if (command_line_->HasSwitch(switches::kEnableSyncDictionary)) {
+#if !defined(OS_ANDROID) && !defined(OS_MACOSX)
groby-ooo-7-16 2013/02/01 22:27:56 I'd rather explicitly enable it for a fixed set of
please use gerrit instead 2013/02/01 22:34:29 Done.
+ // Dictionary sync is enabled by default.
+ if (!command_line_->HasSwitch(switches::kDisableSyncDictionary)) {
pss->RegisterDataTypeController(
new UIDataTypeController(syncer::DICTIONARY, this, profile_, pss));
}
+#endif
}
DataTypeManager* ProfileSyncComponentsFactoryImpl::CreateDataTypeManager(
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/sync/test/integration/dictionary_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698