Enable dictionary sync by default

chrome/browser/sync/profile_sync_components_factory_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "build/build_config.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/extensions/api/storage/settings_frontend.h"
 #include "chrome/browser/extensions/app_notification_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 217 matching lines @@
   // Unless it is explicitly disabled, history delete directive sync is
   // enabled whenever full history sync is enabled.
   if (command_line_->HasSwitch(switches::kHistoryEnableFullHistorySync) &&
       !command_line_->HasSwitch(
           switches::kDisableSyncHistoryDeleteDirectives)) {
     pss->RegisterDataTypeController(
         new UIDataTypeController(
             syncer::HISTORY_DELETE_DIRECTIVES, this, profile_, pss));
   }
 
-  // Dictionary sync is disabled by default.  Register only if explicitly
-  // enabled.
-  if (command_line_->HasSwitch(switches::kEnableSyncDictionary)) {
+#if !defined(OS_ANDROID) && !defined(OS_MACOSX)

[groby-ooo-7-16, 2013/02/01 22:27:56]

I'd rather explicitly enable it for a fixed set of platforms than exclude a
fixed set of platforms.

I.e. #if defined(OS_LINUX) || defined (OS_WIN) || defined(OS_CROS)

[please use gerrit instead, 2013/02/01 22:34:29]

Done.

+  // Dictionary sync is enabled by default.
+  if (!command_line_->HasSwitch(switches::kDisableSyncDictionary)) {
     pss->RegisterDataTypeController(
         new UIDataTypeController(syncer::DICTIONARY, this, profile_, pss));
   }
+#endif
 }
 
 DataTypeManager* ProfileSyncComponentsFactoryImpl::CreateDataTypeManager(
     const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>&
         debug_info_listener,
     SyncBackendHost* backend,
     const DataTypeController::TypeMap* controllers,
     DataTypeManagerObserver* observer,
     const FailedDatatypesHandler* failed_datatypes_handler) {
   return new DataTypeManagerImpl(debug_info_listener,
@@ skipping 138 matching lines @@
 ProfileSyncComponentsFactory::SyncComponents
     ProfileSyncComponentsFactoryImpl::CreateSessionSyncComponents(
        ProfileSyncService* profile_sync_service,
         DataTypeErrorHandler* error_handler) {
   SessionModelAssociator* model_associator =
       new SessionModelAssociator(profile_sync_service, error_handler);
   SessionChangeProcessor* change_processor =
       new SessionChangeProcessor(error_handler, model_associator);
   return SyncComponents(model_associator, change_processor);
 }