Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 12096059: Revert 179615 - didn't help by itself. (May need another revert for r179399) (Closed)

Created:
7 years, 10 months ago by kinuko
Modified:
7 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, scheib+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Revert 179615 - didn't help by itself. (May need another revert for r179399) > Revert 179554 - suspected to break browser_tests on Mac 10.6 > > > Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome. > > > > Part of a series of refactoring changes that will enable simpler code in FullscreenController as well as correcting behavior there. This change attempts to make the minimal modifications required in order to have FullscreenController::ToggleFullscreenMode consistently mean fullscreen with no browser chrome on all platforms. > > > > Depends on https://codereview.chromium.org/12018007/ > > > > BUG=169138 > > > > Review URL: https://chromiumcodereview.appspot.com/11896104 > > TBR=scheib@chromium.org > Review URL: https://codereview.chromium.org/12089068 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -87 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 3 chunks +9 lines, -1 line 0 comments Download
A + chrome/browser/ui/browser_commands_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/browser_commands_mac.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.h View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 9 chunks +48 lines, -65 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinuko
7 years, 10 months ago (2013-01-30 13:34:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698